Skip to content

ENT-14917: Cli small improvements - #276

Merged
olehermanse merged 6 commits into
cfengine:mainfrom
victormlg:cli-small-improvements
Nov 6, 2026
Merged

olehermanse merged 6 commits into
cfengine:mainfrom
victormlg:cli-small-improvements

Conversation

@victormlg

Copy link
Copy Markdown
Contributor

No description provided.

@victormlg
victormlg requested a review from larsewi November 5, 2026 08:23
@codecov

codecov Bot commented Nov 5, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 69.23077% with 16 lines in your changes missing coverage. Please review.
✅ Project coverage is 55.05%. Comparing base (2f4c015) to head (d66fb5d).

Files with missing lines Patch % Lines
src/cfengine_cli/initialize_project.py 40.00% 6 Missing ⚠️
...cfengine_cli/cfengine_wrapper/cfengine_commands.py 75.00% 4 Missing ⚠️
...rc/cfengine_cli/cfengine_wrapper/cfengine_utils.py 82.60% 4 Missing ⚠️
.../cfengine_cli/cfengine_wrapper/cfengine_objects.py 0.00% 1 Missing ⚠️
src/cfengine_cli/commands.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #276      +/-   ##
==========================================
+ Coverage   54.65%   55.05%   +0.40%     
==========================================
  Files          33       33              
  Lines        4256     4299      +43     
==========================================
+ Hits         2326     2367      +41     
- Misses       1930     1932       +2     
Files with missing lines Coverage Δ
.../cfengine_cli/cfengine_wrapper/cfengine_objects.py 37.09% <0.00%> (ø)
src/cfengine_cli/commands.py 57.94% <50.00%> (-0.39%) ⬇️
...cfengine_cli/cfengine_wrapper/cfengine_commands.py 33.02% <75.00%> (+3.37%) ⬆️
...rc/cfengine_cli/cfengine_wrapper/cfengine_utils.py 31.47% <82.60%> (+11.69%) ⬆️
src/cfengine_cli/initialize_project.py 75.55% <40.00%> (-2.40%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@larsewi larsewi left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First commit message does not read well. Otherwise LTGM

victormlg and others added 6 commits November 5, 2026 16:36
Previously only stdout was captured, so errors reported on stderr,
such as cf-promises complaining about a duplicate bundle, were
silently lost.

Ticket: ENT-14917

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Signed-off-by: Victor Moene <victor.moene@northern.tech>
Ticket: ENT-14917

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Signed-off-by: Victor Moene <victor.moene@northern.tech>
Ticket: ENT-14917

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Signed-off-by: Victor Moene <victor.moene@northern.tech>
Ticket: ENT-14917

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Signed-off-by: Victor Moene <victor.moene@northern.tech>
Ticket: ENT-14917

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Signed-off-by: Victor Moene <victor.moene@northern.tech>
Ticket: ENT-14917

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Signed-off-by: Victor Moene <victor.moene@northern.tech>
@victormlg
victormlg force-pushed the cli-small-improvements branch from 121269a to d66fb5d Compare November 5, 2026 15:37
@victormlg
victormlg requested a review from larsewi November 5, 2026 15:42
@olehermanse
olehermanse merged commit 82a5d65 into cfengine:main Nov 6, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants